Page MenuHomePhabricator
Differential D2181

[wallet] Remove Wallet dependencies from init.cpp
ClosedPublic
Actions

Authored by Fabien on Dec 7 2018, 15:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING7e1857a25075: [wallet] Remove Wallet dependencies from init.cpp
rABC7e1857a25075: [wallet] Remove Wallet dependencies from init.cpp
Summary

From core : This PR, along with several others, would remove the remaining dependencies from libbitcoin_server.a on libbitcoin_wallet.a.

Depends on D2180

Backport of core PR10762

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10762
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4280
Build 6625: Bitcoin ABC Buildbot (legacy)
Build 6624: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 7 2018, 15:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2018, 15:52
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 7 2018, 15:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 7 2018, 16:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4278: Diff 6294.Dec 7 2018, 16:03
deadalnix requested changes to this revision.Dec 7 2018, 20:12

Some small nits, but overall it's good.

src/init.cpp
47 ↗(On Diff #6294)

Clearly, there was a backport missed here. No big deal, but please figure out which it is.

src/wallet/init.h
38 ↗(On Diff #6294)

Fix comment layout

This revision now requires changes to proceed.Dec 7 2018, 20:12
Fabien updated this revision to Diff 6297.Dec 7 2018, 20:44
Fabien marked an inline comment as done.

Fix comment layout

src/init.cpp
47 ↗(On Diff #6294)

You created this file in commit 00f4b659f3c497bbcd00447221d808b3b2cf0180
There might be something to do to remove this ENABLE_WALLET though, but it is out of scope for this backport.

teamcity added a comment.Dec 7 2018, 20:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 7 2018, 20:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4280: Diff 6297.Dec 7 2018, 20:54
deadalnix added inline comments.Dec 7 2018, 20:58
src/init.cpp
47 ↗(On Diff #6294)

Ha ok :)

deadalnix accepted this revision.Dec 7 2018, 20:59
This revision is now accepted and ready to land.Dec 7 2018, 20:59
Closed by commit rABC7e1857a25075: [wallet] Remove Wallet dependencies from init.cpp (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyDec 7 2018, 21:01
This revision was automatically updated to reflect the committed changes.
deadalnix mentioned this in D3046: Fix D2181 by including DumpRPC.May 16 2019, 12:30
deadalnix mentioned this in rABC0cd601821488: Fix D2181 by including DumpRPC.May 16 2019, 12:33
deadalnix mentioned this in rSTAGING0cd601821488: Fix D2181 by including DumpRPC.Sep 18 2019, 23:33

Revision Contents
Changeset List

PathSize
src/
1 line
10 lines
4 lines
45 lines
qt/
7 lines
wallet/
78 lines
18 lines
52 lines

Diff 6297

View Options

src/Makefile.am

Loading...
View Options

src/bitcoind.cpp

Loading...
View Options

src/init.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/wallet/init.h

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/walletinitinterface.h

Loading...