Simplify "!foo || (foo && bar)" as "!foo || bar"
ClosedPublic
Actions

Authored by Fabien on Dec 16 2018, 17:12.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGd4d594674698: Simplify "!foo || (foo && bar)" as "!foo || bar"
rABCd4d594674698: Simplify "!foo || (foo && bar)" as "!foo || bar"

Summary

Backport of core PR10780

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10780

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4319
Build 6703: Bitcoin ABC Buildbot (legacy)
Build 6702: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 16 2018, 17:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 16 2018, 17:12

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4319: Diff 6349.Dec 16 2018, 17:22

jasonbcox accepted this revision.Dec 18 2018, 00:16

This revision is now accepted and ready to land.Dec 18 2018, 00:16

Closed by commit rABCd4d594674698: Simplify "!foo || (foo && bar)" as "!foo || bar" (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyDec 19 2018, 10:54

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

3 lines

Diff 6349

View Options

Simplify "!foo || (foo && bar)" as "!foo || bar"ClosedPublicActions