Page MenuHomePhabricator

Minor doc update, clarifying intent of 'CInv'
ClosedPublic

Authored by vermorel on Dec 11 2018, 08:20.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGe02aa01cfaaa: Minor doc update, clarifying intent of 'CInv'
rABCe02aa01cfaaa: Minor doc update, clarifying intent of 'CInv'
Test Plan

comment only, code untouched

Diff Detail

Repository
rABC Bitcoin ABC
Branch
protocol-doc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4330
Build 6725: Bitcoin ABC Buildbot (legacy)
Build 6724: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Dec 11 2018, 08:20
deadalnix requested changes to this revision.Dec 11 2018, 16:58
deadalnix added inline comments.
src/protocol.h
421 ↗(On Diff #6328)

Please fix the formatting.

/**
 * Inv(ventory) message data
 * Intended as non-ambiguous identifier of objects (eg. transactions, blocks)
 * held by peers.
 */
This revision now requires changes to proceed.Dec 11 2018, 16:58
deadalnix requested changes to this revision.Dec 14 2018, 08:06
deadalnix added inline comments.
src/protocol.h
422 ↗(On Diff #6333)

The formatting is still screwed up.

This revision now requires changes to proceed.Dec 14 2018, 08:06
This revision is now accepted and ready to land.Dec 20 2018, 12:44
This revision was automatically updated to reflect the committed changes.