Page MenuHomePhabricator
Differential D2315

Create walletdir if datadir doesn't exist and fix tests
ClosedPublic
Actions

Authored by Fabien on Jan 15 2019, 11:56.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING80879f472d25: Create walletdir if datadir doesn't exist and fix tests
rABC80879f472d25: Create walletdir if datadir doesn't exist and fix tests
Summary

Wallet dir defaults to <data_dir>/wallets/ if the data directory does
not exist.

Backport 3/4 of core PR11466 (most of commit 8263f6a)

Depends on D2314

Test Plan
make check

Run the following commands (warning, will rm your local bitcoin data dir
!):

rm -Rf ~/.bitcoin
bitcoind

Check the directory ~/.bitcoin/wallets has been created

./test/functional/test_runner.py keypool-topup multiwallet wallet_hd

walletbackup

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11466_part4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4527
Build 7117: Bitcoin ABC Buildbot (legacy)
Build 7116: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 15 2019, 11:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2019, 11:56
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 15 2019, 11:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2316: Make debugging test crash easier.Jan 15 2019, 11:59
teamcity added a comment.Jan 15 2019, 12:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4527: Diff 6669.Jan 15 2019, 12:07
Fabien edited the summary of this revision. (Show Details)Jan 15 2019, 12:40
deadalnix accepted this revision.Jan 15 2019, 13:09
This revision is now accepted and ready to land.Jan 15 2019, 13:09
Closed by commit rABC80879f472d25: Create walletdir if datadir doesn't exist and fix tests (authored by MeshCollider <dobsonsa68@gmail.com>, committed by Fabien). · Explain WhyJan 15 2019, 20:01
This revision was automatically updated to reflect the committed changes.
markblundeberg mentioned this in D3312: create net-specific data directory early in init process.Jun 13 2019, 05:44
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCe2c909027fbf: create net-specific data directory early in init process.Jun 15 2019, 19:20
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGe2c909027fbf: create net-specific data directory early in init process.Sep 19 2019, 00:21

Revision Contents
Changeset List

PathSize
src/
qt/
8 lines
5 lines
test/
functional/
4 lines
29 lines
test_framework/
3 lines
2 lines
20 lines

Diff 6669

View Options

src/qt/intro.cpp

Loading...
View Options

src/util.cpp

Loading...
View Options

test/functional/keypool-topup.py

Loading...
View Options

test/functional/multiwallet.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/wallet_hd.py

Loading...
View Options

test/functional/walletbackup.py

Loading...