Page MenuHomePhabricator
Differential D2349

fix confusingly named function parameter 'scriptSig'
ClosedPublic
Actions

Authored by markblundeberg on Jan 20 2019, 05:50.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING227d02ac7a0b: fix confusingly named function parameter 'scriptSig'
rABC227d02ac7a0b: fix confusingly named function parameter 'scriptSig'
Summary

scriptSig normally refers to a script, in this case it
was referring to a serialized signature.

Test Plan

trivial change

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mislabelled-checksig-param
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4590
Build 7243: Bitcoin ABC Buildbot (legacy)
Build 7242: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jan 20 2019, 05:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2019, 05:50
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 20 2019, 05:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 20 2019, 05:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4590: Diff 6758!Jan 20 2019, 05:51
markblundeberg added a comment.Jan 20 2019, 06:19
In D2349#53148, @teamcity wrote:

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

I have no idea why this failed... o_O

markblundeberg added a task: T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG.Jan 20 2019, 07:31
Fabien accepted this revision.Jan 20 2019, 10:49
This revision is now accepted and ready to land.Jan 20 2019, 10:49
markblundeberg added a comment.Jan 20 2019, 19:12

Should I land this or wait for the diff testing system to be fixed?

teamcity added a comment.Jan 20 2019, 20:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 20 2019, 20:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4590: Diff 6758.Jan 20 2019, 20:53
Closed by commit rABC227d02ac7a0b: fix confusingly named function parameter 'scriptSig' (authored by Mark Lundeberg). · Explain WhyJan 20 2019, 21:34
This revision was automatically updated to reflect the committed changes.
markblundeberg removed a task: T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG.Feb 15 2019, 17:08

Revision Contents
Changeset List

PathSize
src/
script/
4 lines

Diff 6758

View Options

src/script/interpreter.h

Loading...