Page MenuHomePhabricator
Differential D2346

qa: Remove unused NodeConn members
ClosedPublic
Actions

Authored by Fabien on Jan 19 2019, 17:51.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf213a7c26c78: qa: Remove unused NodeConn members
rABCf213a7c26c78: qa: Remove unused NodeConn members
Summary

Backport of core PR11677

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11677
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4591
Build 7245: Bitcoin ABC Buildbot (legacy)
Build 7244: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 19 2019, 17:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2019, 17:51
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 19 2019, 17:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4584: Diff 6749!Jan 19 2019, 18:06
teamcity added a comment.Jan 19 2019, 18:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix requested changes to this revision.Jan 20 2019, 00:56

You should rebase this on top of something clean. The CI failed for something that looks unrelated to that patch.

The patch itself looks good. The fact that the changes were limited to abc tests illustrates that we probably aren't doing what's best in these and other tests use an alternative to achieve the same end goal. It would be interesting to look into what that alternative is.

This revision now requires changes to proceed.Jan 20 2019, 00:56
Fabien updated this revision to Diff 6759.Jan 20 2019, 10:37

Rebase

teamcity added a comment.Jan 20 2019, 10:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 20 2019, 10:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4591: Diff 6759!Jan 20 2019, 10:40
Fabien added a comment.Jan 20 2019, 10:43

The CI seems to have some trouble, it failed to fetch the diff.
It's likely that the abc-* tests here can be improved, I put it on my todo list but I prefer to do it in a later diff.

teamcity added a comment.Jan 20 2019, 10:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 20 2019, 11:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4591: Diff 6759.Jan 20 2019, 11:05
deadalnix accepted this revision.Jan 20 2019, 14:53
This revision is now accepted and ready to land.Jan 20 2019, 14:53
Closed by commit rABCf213a7c26c78: qa: Remove unused NodeConn members (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJan 21 2019, 08:10
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGINGf213a7c26c78: qa: Remove unused NodeConn members.Sep 18 2019, 21:59

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines
2 lines
test_framework/
2 lines
6 lines
2 lines

Diff 6759

View Options

test/functional/abc-p2p-compactblocks.py

Loading...
View Options

test/functional/abc-sync-chain.py

Loading...
View Options

test/functional/test_framework/comptool.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...