It is failry similar to an insert operation, except it never generates a subtree.
Return false if the key is not found in the tree, true if it is.
Details
Details
- Reviewers
jasonbcox Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGINGbc165fe64bb0: Implement delete function for the RadixTree
rABCbc165fe64bb0: Implement delete function for the RadixTree
Added test cases.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- radixdelete
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4654 Build 7371: Bitcoin ABC Buildbot (legacy) Build 7370: arc lint + arc unit
Event Timeline
| src/test/radix_tests.cpp | ||
|---|---|---|
| 233 ↗ | (On Diff #6719) | Needs a for loop that provides a set of cases where some random values, including min/max values, are inserted and deleted in random order. Additionally, the inserts and deletes should be logged logged so that in the event of a failure, debugging will be possible. |
Comment Actions
Add a synchronize after removing the element from the tree. As it turns out, we may delete the element we just inserted and have to ensure all other threads are past it for correctness. Not a hue deal because this code is going away anyways, but worth fixing for correctness.