Page MenuHomePhabricator
Differential D2395

Cleanups for walletdir PR
ClosedPublic
Actions

Authored by Fabien on Jan 23 2019, 14:14.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGca5977e1ee03: Cleanups for walletdir PR
rABCca5977e1ee03: Cleanups for walletdir PR
Summary

This is a followup for PR11466 backport.
It addresses a few nits and update the files.md doc.

Backport of core PR11726

Test Plan
make check
./test/functional/test_runner.py wallet_multiwallet

Read files.md

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11726
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4666
Build 7395: Bitcoin ABC Buildbot (legacy)
Build 7394: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 23 2019, 14:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2019, 14:14
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 23 2019, 14:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 23 2019, 14:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4665: Diff 6869.Jan 23 2019, 14:30
deadalnix requested changes to this revision.Jan 23 2019, 14:42

You forgot the angle brackets in wallet/walletutil.cpp

This revision now requires changes to proceed.Jan 23 2019, 14:42
Fabien updated this revision to Diff 6874.Jan 23 2019, 17:14

Use angle brackets for new files

teamcity added a comment.Jan 23 2019, 17:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 23 2019, 17:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4666: Diff 6874.Jan 23 2019, 17:27
Fabien added a child revision: D2396: Improve TestNodeCLI output parsing.Jan 23 2019, 17:28
deadalnix accepted this revision.Jan 24 2019, 00:20
This revision is now accepted and ready to land.Jan 24 2019, 00:20
Closed by commit rABCca5977e1ee03: Cleanups for walletdir PR (authored by MeshCollider <dobsonsa68@gmail.com>, committed by Fabien). · Explain WhyJan 24 2019, 07:01
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGINGca5977e1ee03: Cleanups for walletdir PR.Sep 18 2019, 22:04

Revision Contents
Changeset List

PathSize
doc/
9 lines
src/
wallet/
11 lines
2 lines
2 lines
test/
functional/
7 lines

Diff 6874

View Options

doc/files.md

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/walletutil.h

Loading...
View Options

src/wallet/walletutil.cpp

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...