Page MenuHomePhabricator
Differential D2385

[Radix] Have the radix tree cleanup after itself
ClosedPublic
Actions

Authored by deadalnix on Jan 22 2019, 19:09.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGecf8559941a9: [Radix] Have the radix tree cleanup after itself
rABCecf8559941a9: [Radix] Have the radix tree cleanup after itself
Summary

So far, the tree would leak its internals instead of freeing them properly. This patch ensures that the tree will cleanup after itself properly.

Test Plan
../configure --with-sanitizers=address
make src/test/test_bitcoin
./src/test/test_bitcoin -t radix_tests

Checks that there are no more leaks.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
radixfreenode
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4758
Build 7579: Bitcoin ABC Buildbot (legacy)
Build 7578: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 22 2019, 19:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2019, 19:09
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix added a parent revision: D2371: [Radix] Use RCUPtr to keep track of items in the tree.Jan 22 2019, 19:09
teamcity added a subscriber: teamcity.Jan 22 2019, 19:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 22 2019, 19:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4650: Diff 6846!Jan 22 2019, 19:57
jasonbcox accepted this revision.Jan 24 2019, 00:38
jasonbcox added a subscriber: jasonbcox.

Looks like same build failure as before. Not sure why this change would re-introduce it though.

This revision is now accepted and ready to land.Jan 24 2019, 00:38
jasonbcox added a comment.Jan 24 2019, 00:41

nvm I see this diff actually has a dependency on D2336

deadalnix updated this revision to Diff 6901.Jan 24 2019, 13:33

rebase

teamcity added a comment.Jan 24 2019, 13:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 24 2019, 13:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4687: Diff 6901!Jan 24 2019, 13:39
deadalnix updated this revision to Diff 7011.Jan 30 2019, 02:21

rebase

teamcity added a comment.Jan 30 2019, 02:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 30 2019, 02:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4758: Diff 7011.Jan 30 2019, 02:35
Closed by commit rABCecf8559941a9: [Radix] Have the radix tree cleanup after itself (authored by deadalnix). · Explain WhyJan 31 2019, 12:21
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGINGecf8559941a9: [Radix] Have the radix tree cleanup after itself.Sep 18 2019, 22:11
deadalnix mentioned this in D9870: Remove outdated comment in radix.h.Aug 11 2021, 20:15
deadalnix mentioned this in rABC10382f0f1a04: Remove outdated comment in radix.h.Aug 12 2021, 10:28

Revision Contents
Changeset List

PathSize
src/
28 lines

Diff 7011

View Options

src/radix.h

Loading...