Page MenuHomePhabricator

duplicate API CheckTransactionSignatureEncoding -> CheckTransactionECDSASignatureEncoding
ClosedPublic

Authored by markblundeberg on Jan 31 2019, 20:15.

Details

Summary

... the latter for being used in OP_CHECKMULTISIG. Now each of
CHECKDATASIG/CHECKSIG/CHECKMULTISIG calls its own custom encoding checker.

Rationale: We are switching to a different strategy where 64-byte ECDSA
signatures will now also be banned from OP_CHECKMULTISIG once
SCRIPT_ENABLE_SCHNORR activates. (schnorr spec has not yet been updated
on this point). In a child Diff, that behaviour will be added.

Test Plan

behaviour is only duplicated; tests in sigencoding_tests have
been duplicated in accordance.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
duplicate_sigencoding
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4799
Build 7661: Bitcoin ABC Buildbot (legacy)
Build 7660: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 31 2019, 20:17
This revision was automatically updated to reflect the committed changes.