Differential D2480

tests: add LCG pseudorandom module
ClosedPublic
Actions

Authored by markblundeberg on Feb 1 2019, 18:29.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING4831eca13dcf: tests: add LCG pseudorandom module
rABC4831eca13dcf: tests: add LCG pseudorandom module

Summary

(to be used by: sigencoding_tests and radix_tests)

Test Plan

run test_bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Branch

lcg_standalone

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4827
Build 7717: Bitcoin ABC Buildbot (legacy)
Build 7716: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 1 2019, 18:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2019, 18:29

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4820: Diff 7098.Feb 1 2019, 18:45

markblundeberg mentioned this in D2475: sigencoding_tests : use pseudorandom generator for flag patterns.Feb 1 2019, 20:25

markblundeberg added a child revision: D2475: sigencoding_tests : use pseudorandom generator for flag patterns.Feb 1 2019, 20:25

deadalnix requested changes to this revision.Feb 1 2019, 20:59

deadalnix added inline comments.

src/Makefile.test.include
68 ↗	(On Diff #7098)	You need to add the .h here
src/test/lcg.h
15 ↗	(On Diff #7098)	The return value is invalid. Only the upper 32 bits are pseudo random.
20 ↗	(On Diff #7098)	Constructor goes first.
src/test/lcg_tests.cpp
10 ↗	(On Diff #7098)	remove
11 ↗	(On Diff #7098)	You may want to start several starting values.

This revision now requires changes to proceed.Feb 1 2019, 20:59

changed to return 32bit; expand attribution & explanation; more tests

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg marked 5 inline comments as done.Feb 1 2019, 22:23

Mostly small changes. It's looking good overall.

src/Makefile.test.include
69 ↗	(On Diff #7105)	cpp before h
src/test/lcg.h
23 ↗	(On Diff #7105)	You can compute the return value directly here.
24 ↗	(On Diff #7105)	and just use state here :)
src/test/lcg_tests.cpp
14 ↗	(On Diff #7105)	BOOST_CHECK_EQUAL

This revision now requires changes to proceed.Feb 1 2019, 22:26

changed name; misc comments from amaury

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Feb 1 2019, 22:37

This revision is now accepted and ready to land.Feb 1 2019, 22:37

Harbormaster completed remote builds in B4826: Diff 7105.Feb 1 2019, 22:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4827: Diff 7106.Feb 1 2019, 22:50

Closed by commit rABC4831eca13dcf: tests: add LCG pseudorandom module (authored by Mark Lundeberg). · Explain WhyFeb 1 2019, 22:55

This revision was automatically updated to reflect the committed changes.

markblundeberg mentioned this in D2489: fix dependency lcg.h in CMakeLists and Makefile.test.include.Feb 4 2019, 00:25

Diffusion mentioned this in rABC03c203194e39: fix dependency lcg.h in CMakeLists and Makefile.test.include.Feb 4 2019, 02:50

Mark Lundeberg added a commit: rSTAGING4831eca13dcf: tests: add LCG pseudorandom module.Sep 18 2019, 22:12

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING03c203194e39: fix dependency lcg.h in CMakeLists and Makefile.test.include.Sep 18 2019, 22:14

Revision Contents
Changeset List

Path

Size

src/

Makefile.test.include

2 lines

test/

1 line

33 lines

47 lines

Diff 7106

src/Makefile.test.include

Loading...

src/test/CMakeLists.txt

Loading...

src/test/lcg.h

Loading...

src/test/lcg_tests.cpp

Loading...