Page MenuHomePhabricator
Differential D2489

fix dependency lcg.h in CMakeLists and Makefile.test.include
ClosedPublic
Actions

Authored by markblundeberg on Feb 4 2019, 00:24.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING03c203194e39: fix dependency lcg.h in CMakeLists and Makefile.test.include
rABC03c203194e39: fix dependency lcg.h in CMakeLists and Makefile.test.include
Summary

was causing failed gitian

(my bad, was introduced in D2480)

Test Plan

Jason ran the gitian build on this patch successfully.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4852
Build 7767: Bitcoin ABC Buildbot (legacy)
Build 7766: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 4 2019, 00:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2019, 00:24
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
markblundeberg edited the summary of this revision. (Show Details)Feb 4 2019, 00:25
teamcity added a subscriber: teamcity.Feb 4 2019, 00:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg updated this revision to Diff 7145.Feb 4 2019, 00:32
markblundeberg retitled this revision from add missing dependency lcg.h in CMakeLists to fix dependency lcg.h in CMakeLists and Makefile.test.include.

oops, fixed the wrong thing

teamcity added a comment.Feb 4 2019, 00:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 4 2019, 00:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4852: Diff 7144.Feb 4 2019, 00:40
teamcity added a comment.Feb 4 2019, 00:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4853: Diff 7145.Feb 4 2019, 00:48
jasonbcox accepted this revision.Feb 4 2019, 02:13
jasonbcox edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Feb 4 2019, 02:13
Closed by commit rABC03c203194e39: fix dependency lcg.h in CMakeLists and Makefile.test.include (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyFeb 4 2019, 02:50
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING03c203194e39: fix dependency lcg.h in CMakeLists and Makefile.test.include.Sep 18 2019, 22:14

Revision Contents
Changeset List

PathSize
src/
test/
1 line

Diff 7144

View Options

src/test/CMakeLists.txt

Loading...