Merge #10294: [Wallet] unset change position when there is no change
ClosedPublic
Actions

Authored by jasonbcox on Feb 5 2019, 21:40.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGc25af1fd9c0e: Merge #10294: [Wallet] unset change position when there is no change
rABCc25af1fd9c0e: Merge #10294: [Wallet] unset change position when there is no change

Summary

7c58863 [Wallet] unset change position when there is no change on exact match (Gregory Sanders)

Tree-SHA512: ce8b9337e4132e32d80f954258d50938052c833a48e39431649d6adb16e3d18626a0ae5d300827e7fa397927fba72a1f066cb31af9b0a3ef7f1feb6024461626

Backport of Core PR10294
https://github.com/bitcoin/bitcoin/pull/10294/files
Completes T535

Test Plan

make check
test_runner.py rpc_fundrawtransaction

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr10294

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4881
Build 7825: Bitcoin ABC Buildbot (legacy)
Build 7824: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 5 2019, 21:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 5 2019, 21:40

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4881: Diff 7189.Feb 5 2019, 21:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Feb 5 2019, 22:12

This revision is now accepted and ready to land.Feb 5 2019, 22:12

Closed by commit rABCc25af1fd9c0e: Merge #10294: [Wallet] unset change position when there is no change (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyFeb 5 2019, 22:30

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGINGc25af1fd9c0e: Merge #10294: [Wallet] unset change position when there is no change.Sep 18 2019, 22:16

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

1 line

test/

functional/

rpc_fundrawtransaction.py

7 lines

Diff 7189

View Options

src/wallet/wallet.cpp