Use ToHex() in rpc_decodescript.py, remove dependency to mininode
ClosedPublic
Actions

Authored by Fabien on Feb 11 2019, 13:06.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING06092e020159: Use ToHex() in rpc_decodescript.py, remove dependency to mininode
rABC06092e020159: Use ToHex() in rpc_decodescript.py, remove dependency to mininode

Summary

Avoid using the long form bytes_to_hex_str(obj.serialize()) and remove
the global import from mininode.

Test Plan

./test/functional/test_runner.py rpc_decodescript

Diff Detail

Repository

rABC Bitcoin ABC

Branch

to_hex_decodescript

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4957
Build 7977: Bitcoin ABC Buildbot (legacy)
Build 7976: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 11 2019, 13:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 11 2019, 13:06

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4957: Diff 7297.Feb 11 2019, 13:20

jasonbcox accepted this revision.Feb 11 2019, 17:52

This revision is now accepted and ready to land.Feb 11 2019, 17:52

Closed by commit rABC06092e020159: Use ToHex() in rpc_decodescript.py, remove dependency to mininode (authored by Fabien). · Explain WhyFeb 11 2019, 18:33

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING06092e020159: Use ToHex() in rpc_decodescript.py, remove dependency to mininode.Sep 18 2019, 22:22

Revision Contents
Changeset List

Path

Size

test/

functional/

rpc_decodescript.py

14 lines

Diff 7297

View Options

test/functional/rpc_decodescript.py

Use ToHex() in rpc_decodescript.py, remove dependency to mininodeClosedPublicActions