Page MenuHomePhabricator
Differential D2559

fix Qt crash
ClosedPublic
Actions

Authored by markblundeberg on Feb 16 2019, 03:02.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGeafa2b46d818: fix Qt crash
rABCeafa2b46d818: fix Qt crash
Summary

introduced in D2322 backport

Didn't affect most people, only those who had custom fee selected (which required using Coin Control)

Workaround for affected users: change nCustomFeeRadio=1 to nCustomFeeRadio=0 in the ~/.config/BitcoinABC/<whatever>.conf file.

same fix was also required in core: https://github.com/bitcoin/bitcoin/pull/11332

Test Plan

it runs now!

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-crash
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5003
Build 8069: Bitcoin ABC Buildbot (legacy)
Build 8068: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 16 2019, 03:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 16 2019, 03:02
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 16 2019, 03:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 16 2019, 03:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5003: Diff 7365.Feb 16 2019, 03:18
jasonbcox accepted this revision.Feb 16 2019, 03:22
This revision is now accepted and ready to land.Feb 16 2019, 03:22
markblundeberg updated this revision to Diff 7366.Feb 16 2019, 03:35

add release note

teamcity added a comment.Feb 16 2019, 03:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg updated this revision to Diff 7367.Feb 16 2019, 03:40

s/Qt/bitcoin-qt

Closed by commit rABCeafa2b46d818: fix Qt crash (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyFeb 16 2019, 03:41
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Feb 16 2019, 03:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 16 2019, 03:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5004: Diff 7366.Feb 16 2019, 03:51
teamcity added a comment.Feb 16 2019, 03:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5005: Diff 7367.Feb 16 2019, 03:55
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGeafa2b46d818: fix Qt crash.Sep 18 2019, 22:25

Revision Contents
Changeset List

PathSize
src/
qt/
5 lines

Diff 7365

View Options

src/qt/sendcoinsdialog.cpp

Loading...