Page MenuHomePhabricator
Differential D2628

Leave IBD in rpc_listtransactions
ClosedPublic
Actions

Authored by Fabien on Feb 28 2019, 14:07.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa926b9f1f476: Leave IBD in rpc_listtransactions
rABCa926b9f1f476: Leave IBD in rpc_listtransactions
Summary

The test won't run alone because IBD will prevent the inital
sync_all() to sync the mempools.

Test Plan
./test/functional/test_runner.py rpc_listtransactions

Will fail before the diff, but not after.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rpc_listtransaction_leave_ibd
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5106
Build 8275: Bitcoin ABC Buildbot (legacy)
Build 8274: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 28 2019, 14:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2019, 14:07
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 28 2019, 14:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5106: Diff 7523.Feb 28 2019, 14:20
teamcity added a comment.Feb 28 2019, 14:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien added a child revision: D2629: Remove enable_mocktime in rpc_listtransactions.Feb 28 2019, 15:49
deadalnix accepted this revision.Feb 28 2019, 17:20

Please just backport the changes in the test and code associated instead of redoing everything next time.

This revision is now accepted and ready to land.Feb 28 2019, 17:20
Fabien added a comment.Feb 28 2019, 18:07

Oh I didn't noticed there was a backport for this, I did a quick search but missed it.
Thanks for pointing that, I will backport the other changes as well.

Closed by commit rABCa926b9f1f476: Leave IBD in rpc_listtransactions (authored by Fabien). · Explain WhyFeb 28 2019, 18:46
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D2636: Remove unused enable/disable_mocktime() from test_framework.py.Mar 1 2019, 12:53
Fabien mentioned this in rABC9c4b292b724f: Remove unused enable/disable_mocktime() from test_framework.py.Mar 1 2019, 14:17
Fabien added a commit: rSTAGINGa926b9f1f476: Leave IBD in rpc_listtransactions.Sep 18 2019, 22:33
Fabien mentioned this in rSTAGING9c4b292b724f: Remove unused enable/disable_mocktime() from test_framework.py.Sep 18 2019, 22:37

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines

Diff 7523

View Options

test/functional/rpc_listtransactions.py

Loading...