Remove enable_mocktime from wallet_listreceivedby
ClosedPublic
Actions

Authored by Fabien on Mar 1 2019, 12:22.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING1ddf95e15d4c: Remove enable_mocktime from wallet_listreceivedby
rABC1ddf95e15d4c: Remove enable_mocktime from wallet_listreceivedby

Summary

The enable_mocktime() call has been resurrected in D2465.
However this line is not necessary and should have been removed with
D1983 because it is part of core PR11055.

Test Plan

./test/functional/test_runner.py wallet_listreceivedby

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove_enable_mocktime_wallet_listreceivedby

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5116
Build 8295: Bitcoin ABC Buildbot (legacy)
Build 8294: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 1 2019, 12:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2019, 12:22

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5116: Diff 7552.Mar 1 2019, 12:36

Fabien added a child revision: D2636: Remove unused enable/disable_mocktime() from test_framework.py.Mar 1 2019, 12:53

deadalnix accepted this revision.Mar 1 2019, 14:04

This revision is now accepted and ready to land.Mar 1 2019, 14:04

Closed by commit rABC1ddf95e15d4c: Remove enable_mocktime from wallet_listreceivedby (authored by Fabien). · Explain WhyMar 1 2019, 14:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING1ddf95e15d4c: Remove enable_mocktime from wallet_listreceivedby.Sep 18 2019, 22:36

Revision Contents
Changeset List

Path

Size

test/

functional/

wallet_listreceivedby.py

1 line

Diff 7552

View Options

test/functional/wallet_listreceivedby.py

Remove enable_mocktime from wallet_listreceivedbyClosedPublicActions