Page MenuHomePhabricator

[Part 1 of 2] [qa] receivedby.py cleanup and fixes
ClosedPublic

Authored by schancel on Oct 29 2018, 23:25.

Details

Summary

[qa] Tidy up receivedby.py

  • Fix flake8 warnings
  • Remove the useless get_sub_array_from_array() function
  • Reduce runtime for receivedby.py by about half by only using two nodes

Backport of Core PR11055

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Oct 29 2018, 23:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2018, 23:25
schancel edited the summary of this revision. (Show Details)Oct 30 2018, 00:06
jasonbcox accepted this revision.Oct 30 2018, 00:07
This revision is now accepted and ready to land.Oct 30 2018, 00:07
Closed by commit rABC7e5ed0e6b988: [Part 1 of 2] [qa] receivedby.py cleanup and fixes (authored by John Newbery <john@johnnewbery.com>, committed by schancel). · Explain WhyOct 30 2018, 00:17
This revision was automatically updated to reflect the committed changes.