Page MenuHomePhabricator
Differential D2632

Fix undefined behavior in rpc/server.cpp
ClosedPublic
Actions

Authored by jasonbcox on Mar 1 2019, 00:55.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGed234bd3bb18: Fix undefined behavior in rpc/server.cpp
rABCed234bd3bb18: Fix undefined behavior in rpc/server.cpp
Summary

Calling std::move() on command while dereferencing GetName() is undefined.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D2632
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5121
Build 8305: Bitcoin ABC Buildbot (legacy)
Build 8304: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 1 2019, 00:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2019, 00:55
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox mentioned this in D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.Mar 1 2019, 00:56
teamcity added a subscriber: teamcity.Mar 1 2019, 00:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 1 2019, 01:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5112: Diff 7547.Mar 1 2019, 01:08
Fabien accepted this revision.Mar 1 2019, 07:14
This revision is now accepted and ready to land.Mar 1 2019, 07:14
deadalnix requested changes to this revision.Mar 1 2019, 13:59
deadalnix added inline comments.
src/rpc/server.cpp
71 ↗(On Diff #7547)

You are introducing a copy here for no good reason.

This revision now requires changes to proceed.Mar 1 2019, 13:59
jasonbcox updated this revision to Diff 7562.Mar 1 2019, 22:33

Fix unnecessary copy

teamcity added a comment.Mar 1 2019, 22:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 1 2019, 22:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5121: Diff 7562.Mar 1 2019, 22:47
deadalnix accepted this revision.Mar 2 2019, 00:44
This revision is now accepted and ready to land.Mar 2 2019, 00:44
Closed by commit rABCed234bd3bb18: Fix undefined behavior in rpc/server.cpp (authored by jasonbcox). · Explain WhyMar 2 2019, 01:32
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGed234bd3bb18: Fix undefined behavior in rpc/server.cpp.Sep 18 2019, 22:37

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines
3 lines

Diff 7562

View Options

src/rpc/command.h

Loading...
View Options

src/rpc/server.cpp

Loading...