Page MenuHomePhabricator
Differential D2659

[CMAKE] Add the linker flags to make the relocated sections read only
AbandonedPublic
Actions

Authored by Fabien on Mar 6 2019, 15:20.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This is part of the binary hardening process.

Depends on D2657

Test Plan
make buildcmake && cd buildcmake
cmake -GNinja ..
ninja -v
../contrib/devtools/security-check.py src/bitcoind

Before the patch, the output of the security-check script would
contain 'RELRO`, no longer after the patch.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_hardening_relro
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5165
Build 8393: Bitcoin ABC Buildbot (legacy)
Build 8392: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 6 2019, 15:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2019, 15:20
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 6 2019, 15:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 6 2019, 15:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5165: Diff 7621.Mar 6 2019, 15:35
Fabien planned changes to this revision.Mar 8 2019, 12:55

Need an option to disable hardening

Fabien updated this revision to Diff 7672.Mar 11 2019, 13:14

Rebase on top of D2674

teamcity added a comment.Mar 11 2019, 13:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 11 2019, 13:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5202: Diff 7672.Mar 11 2019, 13:28
Fabien mentioned this in D2687: [CMAKE] Harden the executables.Mar 13 2019, 13:51
Fabien planned changes to this revision.Mar 13 2019, 14:52

Superseeded by D2687, can be removed when landed.

Fabien mentioned this in rABCa423ecd14cd9: [CMAKE] Harden the executables.Mar 20 2019, 13:46
Fabien added a comment.Mar 20 2019, 17:32

Superseeded by D2687

Fabien abandoned this revision.Mar 20 2019, 17:32

Superseeded by D2687

Fabien mentioned this in rSTAGINGa423ecd14cd9: [CMAKE] Harden the executables.Sep 18 2019, 22:45

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 7621

View Options

src/CMakeLists.txt

Loading...