Page MenuHomePhabricator

[CMAKE] Add an append_flag_to_variable facility
AbandonedPublic

Authored by Fabien on Wed, Mar 6, 11:55.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This diff adds a macro for appending a flag to a given variable. This is
a refactoring only change.

Depends on D2653

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja -v

Check the flags are correctly added to the command lines.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_add_flag_to_var
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5159
Build 8381: Bitcoin ABC Teamcity Staging
Build 8380: arc lint + arc unit

Event Timeline

Fabien created this revision.Wed, Mar 6, 11:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 6, 11:55
Herald added a subscriber: schancel. · View Herald Transcript
Fabien planned changes to this revision.Wed, Mar 6, 11:56
Fabien updated this revision to Diff 7615.Wed, Mar 6, 12:03

Fix wrong rebase

deadalnix requested changes to this revision.Thu, Mar 7, 16:45

Unless there is something more that append_flag_to_variable is supposed to do, this really sound to me like the kind of contraption you'd find in J2EE. Command line are space agnostics, so it really doesn't matter, and create a level of indirection for nothing.

This revision now requires changes to proceed.Thu, Mar 7, 16:45
Fabien abandoned this revision.Fri, Mar 8, 08:43

This is purely aesthetic, no functional change intended here. If you're uncomfortable with it I can just abandon it, it won't hurt.