Page MenuHomePhabricator

[CMAKE] Add DEBUG and DEBUG_LOCKORDER definitions to the Debug config
ClosedPublic

Authored by Fabien on Mar 6 2019, 12:39.

Details

Summary

This add definitions for DEBUG and DEBUG_LOCKORDER when the Debug
build type is used.
This allow the use of cmake -GNinja -DCMAKE_BUILD_TYPE=Debug as an
equivalent to configure --enable-debug.

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug
ninja -v

Check that the -DDEBUG -DDEBUG_LOCKORDER flags are added to the
CXX compile lines.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mar 6 2019, 12:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2019, 12:39
Herald added a subscriber: schancel. · View Herald Transcript
Fabien updated this revision to Diff 7655.Mar 8 2019, 12:50

Rebase

Fabien edited the summary of this revision. (Show Details)Mar 8 2019, 12:51
Fabien edited the test plan for this revision. (Show Details)
jasonbcox accepted this revision.Mar 15 2019, 16:51
This revision is now accepted and ready to land.Mar 15 2019, 16:51
This revision was automatically updated to reflect the committed changes.