Page MenuHomePhabricator
Differential D2656

[CMAKE] Add DEBUG and DEBUG_LOCKORDER definitions to the Debug config
ClosedPublic
Actions

Authored by Fabien on Mar 6 2019, 12:39.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGa4e4876986e2: [CMAKE] Add DEBUG and DEBUG_LOCKORDER definitions to the Debug config
rABCa4e4876986e2: [CMAKE] Add DEBUG and DEBUG_LOCKORDER definitions to the Debug config
Summary

This add definitions for DEBUG and DEBUG_LOCKORDER when the Debug
build type is used.
This allow the use of cmake -GNinja -DCMAKE_BUILD_TYPE=Debug as an
equivalent to configure --enable-debug.

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug
ninja -v

Check that the -DDEBUG -DDEBUG_LOCKORDER flags are added to the
CXX compile lines.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_add_debug_definitions
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5162
Build 8387: Bitcoin ABC Buildbot (legacy)
Build 8386: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 6 2019, 12:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2019, 12:39
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 6 2019, 12:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 6 2019, 12:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5162: Diff 7618.Mar 6 2019, 12:53
Fabien updated this revision to Diff 7655.Mar 8 2019, 12:50

Rebase

teamcity added a comment.Mar 8 2019, 12:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Mar 8 2019, 12:51
Fabien edited the test plan for this revision. (Show Details)
Fabien removed a parent revision: D2654: [CMAKE] Add an append_flag_to_variable facility.
teamcity added a comment.Mar 8 2019, 13:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5190: Diff 7655.Mar 8 2019, 13:04
jasonbcox accepted this revision.Mar 15 2019, 16:51
This revision is now accepted and ready to land.Mar 15 2019, 16:51
Closed by commit rABCa4e4876986e2: [CMAKE] Add DEBUG and DEBUG_LOCKORDER definitions to the Debug config (authored by Fabien). · Explain WhyMar 19 2019, 09:47
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGINGa4e4876986e2: [CMAKE] Add DEBUG and DEBUG_LOCKORDER definitions to the Debug config.Sep 18 2019, 22:44

Revision Contents
Changeset List

PathSize
src/
5 lines

Diff 7618

View Options

src/CMakeLists.txt

Loading...