Page MenuHomePhabricator
Differential D2654

[CMAKE] Add an append_flag_to_variable facility
AbandonedPublic
Actions

Authored by Fabien on Mar 6 2019, 11:55.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This diff adds a macro for appending a flag to a given variable. This is
a refactoring only change.

Depends on D2653

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja -v

Check the flags are correctly added to the command lines.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_add_flag_to_var
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5158
Build 8379: Bitcoin ABC Buildbot (legacy)
Build 8378: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 6 2019, 11:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2019, 11:55
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
Fabien planned changes to this revision.Mar 6 2019, 11:56
teamcity added a subscriber: teamcity.Mar 6 2019, 11:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien updated this revision to Diff 7615.Mar 6 2019, 12:03

Fix wrong rebase

teamcity added a comment.Mar 6 2019, 12:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 6 2019, 12:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5158: Diff 7614.Mar 6 2019, 12:11
teamcity added a comment.Mar 6 2019, 12:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5159: Diff 7615.Mar 6 2019, 12:18
Fabien added a child revision: D2644: [CMAKE] Override the flags for the Debug CMake configuration.Mar 6 2019, 12:26
Fabien mentioned this in D2644: [CMAKE] Override the flags for the Debug CMake configuration.
Fabien added a child revision: D2656: [CMAKE] Add DEBUG and DEBUG_LOCKORDER definitions to the Debug config.Mar 6 2019, 12:39
Fabien added a child revision: D2657: [CMAKE] Check for linker flag support.Mar 6 2019, 14:18
deadalnix requested changes to this revision.Mar 7 2019, 16:45

Unless there is something more that append_flag_to_variable is supposed to do, this really sound to me like the kind of contraption you'd find in J2EE. Command line are space agnostics, so it really doesn't matter, and create a level of indirection for nothing.

This revision now requires changes to proceed.Mar 7 2019, 16:45
Fabien abandoned this revision.Mar 8 2019, 08:43

This is purely aesthetic, no functional change intended here. If you're uncomfortable with it I can just abandon it, it won't hurt.

Fabien removed a child revision: D2657: [CMAKE] Check for linker flag support.Mar 8 2019, 12:10
Fabien removed a child revision: D2644: [CMAKE] Override the flags for the Debug CMake configuration.Mar 8 2019, 12:35
Fabien removed a child revision: D2656: [CMAKE] Add DEBUG and DEBUG_LOCKORDER definitions to the Debug config.Mar 8 2019, 12:51

Revision Contents
Changeset List

PathSize
cmake/
modules/
17 lines

Diff 7614

View Options

cmake/modules/AddCompilerFlags.cmake

Loading...