Add braces in netaddress.{h|cpp}
ClosedPublic
Actions

Authored by deadalnix on Mar 7 2019, 14:27.

Details

Reviewers

Fabien
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING0a37e0354f3c: Add braces in netaddress.{h|cpp}
rABC0a37e0354f3c: Add braces in netaddress.{h|cpp}

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

netaddrnits

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5175
Build 8413: Bitcoin ABC Buildbot (legacy)
Build 8412: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 7 2019, 14:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 7 2019, 14:27

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5171: Diff 7627.Mar 7 2019, 14:42

Fabien requested changes to this revision.Mar 7 2019, 15:17

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/netaddress.cpp
647 ↗	(On Diff #7627)	Missing braces

This revision now requires changes to proceed.Mar 7 2019, 15:17

Add missing braces

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5175: Diff 7633.Mar 7 2019, 17:22

jasonbcox accepted this revision.Mar 7 2019, 18:52

Fabien accepted this revision.Mar 7 2019, 20:26

This revision is now accepted and ready to land.Mar 7 2019, 20:26

Closed by commit rABC0a37e0354f3c: Add braces in netaddress.{h|cpp} (authored by deadalnix). · Explain WhyMar 8 2019, 12:22

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rSTAGING0a37e0354f3c: Add braces in netaddress.{h|cpp}.Sep 18 2019, 22:39

Revision Contents
Changeset List

Path

Size

src/

netaddress.h

4 lines

netaddress.cpp

88 lines

Diff 7633

View Options

src/netaddress.h