Paths

Table of Contentst

Cleanup remaining instances of txconfirmtarget
ClosedPublic
Actions

Authored by jasonbcox on Mar 8 2019, 00:21.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING9a061e3de48f: Cleanup remaining instances of txconfirmtarget
rABC9a061e3de48f: Cleanup remaining instances of txconfirmtarget

Summary

Confirm target is no longer used, so cleaning it up. This operation is safe because now that txconfirmtarget will be simply ignored.

Test Plan

make check
bitcoin-qt # for sanity
bitcoin-qt --help # no longer contains help message for -txconftarget

Added txconfirmtarget=2 to bitcoin.conf
bitcoind operation was not disrupted.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

feecleanup2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5184
Build 8431: Bitcoin ABC Buildbot (legacy)
Build 8430: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 8 2019, 00:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 8 2019, 00:21

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5184: Diff 7647.Mar 8 2019, 00:36

deadalnix accepted this revision.Mar 8 2019, 12:40

This revision is now accepted and ready to land.Mar 8 2019, 12:40

jasonbcox edited the test plan for this revision. (Show Details)Mar 8 2019, 17:18

Closed by commit rABC9a061e3de48f: Cleanup remaining instances of txconfirmtarget (authored by jasonbcox). · Explain WhyMar 8 2019, 17:19

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING9a061e3de48f: Cleanup remaining instances of txconfirmtarget.Sep 18 2019, 22:40

Revision Contents
Changeset List

Path

Size

contrib/

debian/

examples/

bitcoin.conf

4 lines

doc/

release-notes.md

1 line

src/

qt/

bitcoinstrings.cpp

5 lines

locale/

bitcoin_ca.ts

6 lines

bitcoin_ca@valencia.ts

6 lines

6 lines

4 lines

4 lines

4 lines

27 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

6 lines

6 lines

4 lines

4 lines

4 lines

4 lines

4 lines

6 lines

6 lines

4 lines

4 lines

6 lines

4 lines

4 lines

1 line

4 lines

wallet/

1 line

8 lines

3 lines

1 line

Diff 7647

View Options

contrib/debian/examples/bitcoin.conf

View Options

doc/release-notes.md

View Options

src/qt/bitcoinstrings.cpp

View Options

src/qt/locale/bitcoin_ca.ts

View Options

src/qt/locale/bitcoin_ca@valencia.ts

View Options

src/qt/locale/bitcoin_ca_ES.ts

View Options

src/qt/locale/bitcoin_cs.ts

View Options

src/qt/locale/bitcoin_da.ts

View Options

src/qt/locale/bitcoin_de.ts

View Options

src/qt/locale/bitcoin_en.ts

View Options

src/qt/locale/bitcoin_en_GB.ts

View Options

src/qt/locale/bitcoin_es.ts

View Options

src/qt/locale/bitcoin_es_ES.ts

View Options

src/qt/locale/bitcoin_fr.ts

View Options

src/qt/locale/bitcoin_it.ts

View Options

src/qt/locale/bitcoin_ja.ts

View Options

src/qt/locale/bitcoin_ko_KR.ts

View Options

src/qt/locale/bitcoin_nb.ts

View Options

src/qt/locale/bitcoin_ne.ts

View Options

src/qt/locale/bitcoin_nl.ts

View Options

src/qt/locale/bitcoin_pl.ts

View Options

src/qt/locale/bitcoin_pt_BR.ts

View Options

src/qt/locale/bitcoin_pt_PT.ts

View Options

src/qt/locale/bitcoin_ru.ts

View Options

src/qt/locale/bitcoin_sk.ts

View Options

src/qt/locale/bitcoin_sl_SI.ts

View Options

src/qt/locale/bitcoin_sv.ts

View Options

src/qt/locale/bitcoin_tr.ts

View Options

src/qt/locale/bitcoin_uk.ts

View Options

src/qt/locale/bitcoin_zh_CN.ts

View Options

src/qt/locale/bitcoin_zh_TW.ts

View Options

src/qt/walletmodel.h

View Options

src/qt/walletmodel.cpp

View Options

src/wallet/fees.cpp

View Options

src/wallet/init.cpp

View Options

src/wallet/wallet.h

View Options

Cleanup remaining instances of txconfirmtargetClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7647

contrib/debian/examples/bitcoin.conf

doc/release-notes.md

src/qt/bitcoinstrings.cpp

src/qt/locale/bitcoin_ca.ts

src/qt/locale/bitcoin_ca@valencia.ts

src/qt/locale/bitcoin_ca_ES.ts

src/qt/locale/bitcoin_cs.ts

src/qt/locale/bitcoin_da.ts

src/qt/locale/bitcoin_de.ts

src/qt/locale/bitcoin_en.ts

src/qt/locale/bitcoin_en_GB.ts

src/qt/locale/bitcoin_es.ts

src/qt/locale/bitcoin_es_ES.ts

src/qt/locale/bitcoin_fr.ts

src/qt/locale/bitcoin_it.ts

src/qt/locale/bitcoin_ja.ts

src/qt/locale/bitcoin_ko_KR.ts

src/qt/locale/bitcoin_nb.ts

src/qt/locale/bitcoin_ne.ts

src/qt/locale/bitcoin_nl.ts

src/qt/locale/bitcoin_pl.ts

src/qt/locale/bitcoin_pt_BR.ts

src/qt/locale/bitcoin_pt_PT.ts

src/qt/locale/bitcoin_ru.ts

src/qt/locale/bitcoin_sk.ts

src/qt/locale/bitcoin_sl_SI.ts

src/qt/locale/bitcoin_sv.ts

src/qt/locale/bitcoin_tr.ts

src/qt/locale/bitcoin_uk.ts

src/qt/locale/bitcoin_zh_CN.ts

src/qt/locale/bitcoin_zh_TW.ts

src/qt/walletmodel.h

src/qt/walletmodel.cpp

src/wallet/fees.cpp

src/wallet/init.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

Cleanup remaining instances of txconfirmtarget
ClosedPublic
Actions

Revision Contents
Changeset List