Paths

Table of Contentst

[CMAKE] Avoid displaying the console when launching bitcoin-qt.exe
ClosedPublic
Actions

Authored by Fabien on Mar 12 2019, 12:40.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGd5be34457fb9: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe
rABCd5be34457fb9: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe

Summary

This adds a flag which prevents displaying the console when running
bitcoin-qt.exe.

Test Plan

Prerequisite:
Follow the doc/build-windows.md and depends/README.md documentation
and install the dependencies for i686-w64-mingw32 and
x86_64-w64-mingw32.

# 32-bit version
mkdir buildcmake && cd buildcmake
cmake -GNinja .. -DBUILD_BITCOIN_SEEDER=OFF \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win32.cmake
ninja

Check the build succeeds.
Check the generated src/qt/bitcoin-qt.exe binary runs as expected.
Ensure there is no console display when running the exe.

Operate the same for Win64.

# 64-bit version
rm -rf *
cmake -GNinja .. -DBUILD_BITCOIN_SEEDER=OFF \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake
ninja

Check the build succeeds.
Check the generated src/qt/bitcoin-qt.exe binary runs as expected.
Ensure there is no console display when running the exe.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_windows_no_console

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5209
Build 8481: Bitcoin ABC Buildbot (legacy)
Build 8480: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 12 2019, 12:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 12 2019, 12:40

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Fabien edited the summary of this revision. (Show Details)Mar 12 2019, 12:41

Fabien added a parent revision: D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5209: Diff 7684.Mar 12 2019, 12:56

jasonbcox accepted this revision.Mar 12 2019, 15:25

This revision is now accepted and ready to land.Mar 12 2019, 15:25

deadalnix requested changes to this revision.Mar 14 2019, 02:45

deadalnix added inline comments.

src/qt/CMakeLists.txt
164	How this isn't windows only ? What is configure doing ?

This revision now requires changes to proceed.Mar 14 2019, 02:45

Fabien requested review of this revision.Mar 14 2019, 07:08

Fabien added inline comments.

src/qt/CMakeLists.txt
164	Yes, this is windows only. Configure does the same in `bitcoin_qt.m4`: case $host in # [...] mingw) BITCOIN_QT_CHECK([ AX_CHECK_LINK_FLAG([[-mwindows]],[QT_LDFLAGS="$QT_LDFLAGS -mwindows"],[AC_MSG_WARN(-mwindows linker support not detected)]) ]) esac

deadalnix accepted this revision.Mar 27 2019, 02:26

This revision is now accepted and ready to land.Mar 27 2019, 02:26

I discovered by chance that cmake targets have a property which does exactly the same
(setting the exact same flag) in a more cmake fashion way.
This property has no impact if the build is not a windows executable, so no need to
make it explicitely windows only.

Fabien requested review of this revision.Apr 24 2019, 13:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5591: Diff 8257.Apr 24 2019, 14:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Link to the doc: https://cmake.org/cmake/help/v3.10/prop_tgt/WIN32_EXECUTABLE.html#prop_tgt:WIN32_EXECUTABLE

jasonbcox accepted this revision.Apr 24 2019, 16:03

This revision is now accepted and ready to land.Apr 24 2019, 16:03

From the cmake mailing list, this tends to confirm that this property has no impact outside of a windows build: https://cmake.org/pipermail/cmake/2008-March/020577.html

Fabien edited the summary of this revision. (Show Details)May 25 2019, 07:20

Fabien removed a parent revision: D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.

Closed by commit rABCd5be34457fb9: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe (authored by Fabien). · Explain WhyMay 25 2019, 07:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd5be34457fb9: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.

Fabien added a commit: rSTAGINGd5be34457fb9: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.Sep 18 2019, 23:45