Merge #12327: [gui] Defer coin control instancing
ClosedPublic
Actions

Authored by jasonbcox on Mar 15 2019, 23:28.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING6a8115b98cca: Merge #12327: [gui] Defer coin control instancing
rABC6a8115b98cca: Merge #12327: [gui] Defer coin control instancing

Summary

6558f8acc [gui] Defer coin control instancing (João Barbosa)

Pull request description:

Defer the GUI coin control instancing so that argument processing
is taken into account for the default coin control values.

Fixes #12312

Tree-SHA512: ecda28b94f4709319e9484b01afe763c7c3569097d2afb89db79da8a195c46d20ea77166df7edce0c8ab77627b295def01c072148714503436d27675d5e75d99

Backport of Core PR 12327
https://github.com/bitcoin/bitcoin/pull/12327/files
Completes T556

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr12327

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5226
Build 8515: Bitcoin ABC Buildbot (legacy)
Build 8514: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 15 2019, 23:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 15 2019, 23:28

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5226: Diff 7715.Mar 15 2019, 23:44

Fabien accepted this revision.Mar 16 2019, 08:21

This revision is now accepted and ready to land.Mar 16 2019, 08:21

Closed by commit rABC6a8115b98cca: Merge #12327: [gui] Defer coin control instancing (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by jasonbcox). · Explain WhyMar 16 2019, 15:48

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING6a8115b98cca: Merge #12327: [gui] Defer coin control instancing.Sep 18 2019, 22:43

Revision Contents
Changeset List

Path

Size

src/

qt/

coincontroldialog.h

2 lines

coincontroldialog.cpp

22 lines

sendcoinsdialog.cpp

20 lines

Diff 7715

View Options

src/qt/coincontroldialog.h

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/sendcoinsdialog.cpp

Merge #12327: [gui] Defer coin control instancingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7715

src/qt/coincontroldialog.h

src/qt/coincontroldialog.cpp

src/qt/sendcoinsdialog.cpp

Merge #12327: [gui] Defer coin control instancing
ClosedPublic
Actions

Revision Contents
Changeset List