Page MenuHomePhabricator
Differential D2728

Remove unused seeder/compat.h
ClosedPublic
Actions

Authored by Fabien on Mar 22 2019, 12:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING298b6cbf751c: Remove unused seeder/compat.h
rABC298b6cbf751c: Remove unused seeder/compat.h
Summary

This file is no longer used in the seeder since it is included in the
main tree (src/compat.h is used).

Test Plan
./autogen.sh
mkdir build && cd build
../configure
make
./src/bitcoin-seeder

Ensure the software runs as expected

cd ..
mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja
./src/bitcoin-seeder

Ensure the software runs as expected

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove_seeder_compat
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5272
Build 8607: Bitcoin ABC Buildbot (legacy)
Build 8606: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 22 2019, 12:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 22 2019, 12:04
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 22 2019, 12:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 22 2019, 12:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5272: Diff 7786.Mar 22 2019, 12:18
deadalnix accepted this revision.Mar 22 2019, 12:39
This revision is now accepted and ready to land.Mar 22 2019, 12:39
Closed by commit rABC298b6cbf751c: Remove unused seeder/compat.h (authored by Fabien). · Explain WhyMar 22 2019, 16:04
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D2733: Fix seeder in the gitian build.Mar 25 2019, 18:16
jasonbcox mentioned this in rABCfe7f30d365c1: Fix seeder in the gitian build.Mar 25 2019, 19:56
Fabien added a commit: rSTAGING298b6cbf751c: Remove unused seeder/compat.h.Sep 18 2019, 22:47
jasonbcox mentioned this in rSTAGINGfe7f30d365c1: Fix seeder in the gitian build.Sep 18 2019, 22:48

Revision Contents
Changeset List

PathSize
src/
seeder/

Diff 7786

View Options

src/seeder/compat.h

Loading...