[CMAKE] Move .h files transformed from .ui to the form subdirectory
AbandonedPublic
Actions

Authored by Fabien on Mar 28 2019, 15:14.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Summary

This is a prerequisite for PR11651, as all the qt headers will be
included with their path relative to src/.

Example: #include "ui_intro.h will become `#include
<qt/forms/ui_intro.h>`.

The ui_*.h files generated from the *.ui files are generated by
qt5_wrap_ui in the CMakeLists.txt file directory, wherever the
source *.ui files are located.

This diffs move the translation to a new CMakeLists.txt located in the
qt/forms subdirectory, so the ui_*.h files are generated here.

Test Plan

mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_move_ui_files_forms

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5324
Build 8710: Bitcoin ABC Buildbot (legacy)
Build 8709: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 28 2019, 15:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 28 2019, 15:14

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B5324: Diff 7860!Mar 28 2019, 15:28

You removed parallelism for no good reason.

This revision now requires changes to proceed.Apr 3 2019, 19:59

deadalnix added inline comments.Apr 3 2019, 19:59

src/qt/forms/CMakeLists.txt
6	That's not how it is done.

Fabien mentioned this in D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.Apr 8 2019, 15:32

Fabien mentioned this in rABC1187488597aa: [CMAKE] Move .h files transformed from .ui to the form subdirectory.Apr 16 2019, 08:07

Superseeded by D2786

src/qt/forms/CMakeLists.txt
6	This is required to define `qt5_wrap_ui` in this scope. A similar thing is done for the locale generation which finds `Qt5LinguistTools` to get `qt5_add_translation`.