Page MenuHomePhabricator
Differential D2756

[secp256k1] refactor nativeECDSABuffer to a more generic name
ClosedPublic
Actions

Authored by floreslorca on Mar 31 2019, 00:17.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING951510874e5a: [secp256k1] refactor nativeECDSABuffer to a more generic name
rABC951510874e5a: [secp256k1] refactor nativeECDSABuffer to a more generic name
Summary

refactor to a generic name since know we use schnorr sigs

Test Plan

java tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
refactor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5336
Build 8734: Bitcoin ABC Buildbot (legacy)
Build 8733: arc lint + arc unit

Event Timeline

floreslorca created this revision.Mar 31 2019, 00:17
Owners added a reviewer: Restricted Owners Package.Mar 31 2019, 00:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 31 2019, 00:17
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a comment.Mar 31 2019, 00:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 31 2019, 00:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5336: Diff 7881.Mar 31 2019, 00:33
jasonbcox accepted this revision.Apr 2 2019, 01:10
This revision is now accepted and ready to land.Apr 2 2019, 01:10
jasonbcox mentioned this in D2755: [secp256k1] add schnorr sign jni binding.Apr 2 2019, 01:27
Closed by commit rABC951510874e5a: [secp256k1] refactor nativeECDSABuffer to a more generic name (authored by floreslorca). · Explain WhyApr 9 2019, 17:14
This revision was automatically updated to reflect the committed changes.
floreslorca added a commit: rSTAGING951510874e5a: [secp256k1] refactor nativeECDSABuffer to a more generic name.Sep 19 2019, 14:55

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
java/
org/
bitcoin/
46 lines

Diff 7881

View Options

src/secp256k1/src/java/org/bitcoin/NativeSecp256k1.java

Loading...