Page MenuHomePhabricator
Differential D2764

[LINTER] Enforce custom coding standard for PHP files
ClosedPublic
Actions

Authored by Fabien on Apr 2 2019, 12:54.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGdb99036786ac: [LINTER] Enforce custom coding standard for PHP files
rABCdb99036786ac: [LINTER] Enforce custom coding standard for PHP files
Summary

These rules are close to Pḧabricator standard.
Requires the installation of phpcs on the local machine.

Depends on D2760

Test Plan

Should return no error:

arc lint -- arcanist/linter*

Add a tab at the beginning of a line in any of the
arcanist/linter/*.php file, then:

arc lint -- arcanist/linter*

The error should be reported.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
phpcs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5390
Build 8842: Bitcoin ABC Buildbot (legacy)
Build 8841: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 2 2019, 12:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 2 2019, 12:54
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a comment.Apr 2 2019, 12:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 2 2019, 13:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5356: Diff 7906.Apr 2 2019, 13:10
Fabien updated this revision to Diff 7939.Apr 4 2019, 07:32

Exclude comment blocks from strict alignment

teamcity added a comment.Apr 4 2019, 07:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5378: Diff 7939.Apr 4 2019, 07:47
teamcity added a comment.Apr 4 2019, 07:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien updated this revision to Diff 7960.Apr 5 2019, 10:14

Exclude object operator from the strict indentation check

teamcity added a comment.Apr 5 2019, 10:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added inline comments.Apr 5 2019, 10:22
arcanist/linter/phpcs_ruleset.xml
41

Note to reviewers: theses 2 tokens are exception to the indentation check.
They are excluded because there is no built-in rule in any standard that enforce:

  • Multiline comment stars alignment (only doc comments are supported):
/*
 * Comment with aligned stars
 */
  • Multiline statement indentation when outside of a function, array or control structure.

These rules need to be enforced in their own PHP sniffer scripts, which may better be added in other diffs.
These exceptions ensure that the produced code can still be compliant with our rules.

Harbormaster completed remote builds in B5390: Diff 7960.Apr 5 2019, 10:29
teamcity added a comment.Apr 5 2019, 10:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Apr 15 2019, 11:52
This revision is now accepted and ready to land.Apr 15 2019, 11:52
Closed by commit rABCdb99036786ac: [LINTER] Enforce custom coding standard for PHP files (authored by Fabien). · Explain WhyApr 15 2019, 13:52
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGINGdb99036786ac: [LINTER] Enforce custom coding standard for PHP files.Sep 18 2019, 22:57

Revision Contents
Changeset List

PathSize
8 lines
arcanist/
linter/
49 lines

Diff 7960

View Options

.arclint

Loading...
View Options

arcanist/linter/phpcs_ruleset.xml

Loading...