Page MenuHomePhabricator

Format the php files
ClosedPublic

Authored by Fabien on Mon, Apr 1, 16:12.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC4c92f4c7b84f: Format the php files
Summary

This is a prerequisite to enforcing a custom phabricator-like coding standard through a linter.

Test Plan

Should run with no exception:

arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Apr 1, 16:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Apr 1, 16:12
Herald added a subscriber: schancel. · View Herald Transcript
Fabien planned changes to this revision.Mon, Apr 1, 19:41

I will define a custom ruleset to make it closer to original's standard.

Fabien updated this revision to Diff 7904.Tue, Apr 2, 12:46

Update formatting to something close to phabricator standard

deadalnix requested changes to this revision.Wed, Apr 3, 20:00
deadalnix added inline comments.
arcanist/linter/AutoPEP8Linter.php
48 ↗(On Diff #7904)

This is quite apparently broken.

This revision now requires changes to proceed.Wed, Apr 3, 20:00
Fabien retitled this revision from Format the php files, make them compliant to PSR2 to Format the php files.Thu, Apr 4, 06:21
Fabien edited the summary of this revision. (Show Details)
Fabien updated this revision to Diff 7938.Thu, Apr 4, 07:29

Fix comment alignment

arcanist/linter/AutoPEP8Linter.php
48 ↗(On Diff #7904)

Good catch

deadalnix requested changes to this revision.Thu, Apr 4, 15:00
deadalnix added inline comments.
arcanist/linter/TestsLinter.php
140 ↗(On Diff #7938)

The indentation is wrong here and all similar patterns.

This revision now requires changes to proceed.Thu, Apr 4, 15:00
Fabien updated this revision to Diff 7959.Fri, Apr 5, 10:13

Indent multiline statements outside of a control block

deadalnix accepted this revision.Fri, Apr 5, 12:42
This revision is now accepted and ready to land.Fri, Apr 5, 12:42
This revision was automatically updated to reflect the committed changes.