Page MenuHomePhabricator
Differential D2760

Format the php files
ClosedPublic
Actions

Authored by Fabien on Apr 1 2019, 16:12.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING4c92f4c7b84f: Format the php files
rABC4c92f4c7b84f: Format the php files
Summary

This is a prerequisite to enforcing a custom phabricator-like coding standard through a linter.

Test Plan

Should run with no exception:

arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lint_php_files
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5377
Build 8816: Bitcoin ABC Buildbot (legacy)
Build 8815: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 1 2019, 16:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2019, 16:12
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a comment.Apr 1 2019, 16:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 1 2019, 16:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5343: Diff 7889.Apr 1 2019, 16:27
Fabien planned changes to this revision.Apr 1 2019, 19:41

I will define a custom ruleset to make it closer to original's standard.

Fabien updated this revision to Diff 7904.Apr 2 2019, 12:46

Update formatting to something close to phabricator standard

teamcity added a comment.Apr 2 2019, 12:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2764: [LINTER] Enforce custom coding standard for PHP files.Apr 2 2019, 12:54
teamcity added a comment.Apr 2 2019, 13:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5355: Diff 7904.Apr 2 2019, 13:01
deadalnix requested changes to this revision.Apr 3 2019, 20:00
deadalnix added inline comments.
arcanist/linter/AutoPEP8Linter.php
48 ↗(On Diff #7904)

This is quite apparently broken.

This revision now requires changes to proceed.Apr 3 2019, 20:00
Fabien retitled this revision from Format the php files, make them compliant to PSR2 to Format the php files.Apr 4 2019, 06:21
Fabien edited the summary of this revision. (Show Details)
Fabien updated this revision to Diff 7938.Apr 4 2019, 07:29

Fix comment alignment

arcanist/linter/AutoPEP8Linter.php
48 ↗(On Diff #7904)

Good catch

teamcity added a comment.Apr 4 2019, 07:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 4 2019, 07:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5377: Diff 7938.Apr 4 2019, 07:44
deadalnix requested changes to this revision.Apr 4 2019, 15:00
deadalnix added inline comments.
arcanist/linter/TestsLinter.php
140

The indentation is wrong here and all similar patterns.

This revision now requires changes to proceed.Apr 4 2019, 15:00
Fabien updated this revision to Diff 7959.Apr 5 2019, 10:13

Indent multiline statements outside of a control block

teamcity added a comment.Apr 5 2019, 10:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5389: Diff 7959.Apr 5 2019, 10:27
teamcity added a comment.Apr 5 2019, 10:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Apr 5 2019, 12:42
This revision is now accepted and ready to land.Apr 5 2019, 12:42
Closed by commit rABC4c92f4c7b84f: Format the php files (authored by Fabien). · Explain WhyApr 5 2019, 16:02
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING4c92f4c7b84f: Format the php files.Sep 18 2019, 22:53

Revision Contents
Changeset List

Diff 7938

View Options

arcanist/linter/AutoPEP8Linter.php

Loading...
View Options

arcanist/linter/CheckDocLinter.php

Loading...
View Options

arcanist/linter/ClangFormatLinter.php

Loading...
View Options

arcanist/linter/LocalDependenceLinter.php

Loading...
View Options

arcanist/linter/PythonFormatLinter.php

Loading...
View Options

arcanist/linter/TestsLinter.php

Loading...