Page MenuHomePhabricator
Differential D2805

GUI: Receive: Remove option to reuse a previous address
ClosedPublic
Actions

Authored by nakihito on Apr 15 2019, 22:19.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING646720f32fdc: GUI: Receive: Remove option to reuse a previous address
rABC646720f32fdc: GUI: Receive: Remove option to reuse a previous address
Summary

This was justified by the need to "resent" an invoice, but now that we have the request history, that need should be gone.

Backports PR3716
https://github.com/bitcoin/bitcoin/pull/3716/

Completes T599

Test Plan

make check
bitcoin-qt
Under the receive tab, there should be no option to reuse an existing receiving address.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
Backport3716
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5463
Build 8988: Bitcoin ABC Buildbot (legacy)
Build 8987: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 15 2019, 22:19
Owners added a reviewer: Restricted Owners Package.Apr 15 2019, 22:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2019, 22:19
teamcity added a comment.Apr 15 2019, 22:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Apr 15 2019, 22:31
jasonbcox added inline comments.Apr 15 2019, 22:31
doc/release-notes.md
11 ↗(On Diff #8064)

s/removed./removed from the wallet.
just to clarify... (not all node operators are wallet users)

jasonbcox accepted this revision.Apr 15 2019, 22:33
This revision is now accepted and ready to land.Apr 15 2019, 22:33
nakihito updated this revision to Diff 8066.Apr 15 2019, 22:34
nakihito marked an inline comment as done.

Edited release notes to further clarify change in behavior.

teamcity added a comment.Apr 15 2019, 22:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 15 2019, 22:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5461: Diff 8064.Apr 15 2019, 22:34
nakihito updated this revision to Diff 8068.Apr 15 2019, 22:41

rebased.

teamcity added a comment.Apr 15 2019, 22:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

This revision was landed with ongoing or failed builds.Apr 15 2019, 22:42
Closed by commit rABC646720f32fdc: GUI: Receive: Remove option to reuse a previous address (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by nakihito). · Explain Why
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Apr 15 2019, 22:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5462: Diff 8066.Apr 15 2019, 22:48
Harbormaster completed remote builds in B5463: Diff 8068.Apr 15 2019, 22:57
teamcity added a comment.Apr 15 2019, 22:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING646720f32fdc: GUI: Receive: Remove option to reuse a previous address.Sep 18 2019, 22:58

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
qt/
forms/
22 lines
23 lines

Diff 8068

View Options

doc/release-notes.md

Loading...
View Options

src/qt/forms/receivecoinsdialog.ui

Loading...
View Options

src/qt/receivecoinsdialog.cpp

Loading...