Page MenuHomePhabricator
Differential D2827

Added missing notes to release notes
ClosedPublic
Actions

Authored by jasonbcox on Apr 18 2019, 21:44.

Details

Reviewers
deadalnix
Fabien
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGINGf2225b39dcc4: Added missing notes to release notes
rABCf2225b39dcc4: Added missing notes to release notes
Summary

Prepping for release

Test Plan

Read it

Diff Detail

Repository
rABC Bitcoin ABC
Branch
releasenotes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5510
Build 9082: Bitcoin ABC Buildbot (legacy)
Build 9081: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 18 2019, 21:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2019, 21:44
teamcity added a comment.Apr 18 2019, 21:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien accepted this revision.Apr 18 2019, 21:57
This revision is now accepted and ready to land.Apr 18 2019, 21:57
teamcity added a comment.Apr 18 2019, 21:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5507: Diff 8126.Apr 18 2019, 21:58
jasonbcox updated this revision to Diff 8129.Apr 18 2019, 22:23

Added note about getinfo

jasonbcox retitled this revision from Added Schnorr bindings to release notes to Added missing notes to release notes.Apr 18 2019, 22:23
teamcity added a comment.Apr 18 2019, 22:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien requested changes to this revision.Apr 18 2019, 22:29
Fabien added inline comments.
doc/release-notes.md
13

I don't think there is a new rpc here, but only an option to bitcoin-cli

This revision now requires changes to proceed.Apr 18 2019, 22:29
teamcity added a comment.Apr 18 2019, 22:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5510: Diff 8129.Apr 18 2019, 22:38
jasonbcox updated this revision to Diff 8135.Apr 19 2019, 02:53

Fix getinfo note (rpc call -> option)

teamcity added a comment.Apr 19 2019, 02:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 19 2019, 03:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5516: Diff 8135.Apr 19 2019, 03:08
Fabien added inline comments.Apr 19 2019, 07:01
doc/release-notes.md
13 ↗(On Diff #8135)

Added -getinfo option to bitcoin-cli for batching [...]
The option is only available for bitcoin-cli

deadalnix accepted this revision.Apr 19 2019, 12:47
jasonbcox updated this revision to Diff 8188.Apr 20 2019, 16:49

Amended note to indicate only bitcoin-cli

teamcity added a comment.Apr 20 2019, 16:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 20 2019, 17:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5544: Diff 8188.Apr 20 2019, 17:03
Fabien accepted this revision.Apr 21 2019, 07:27
This revision is now accepted and ready to land.Apr 21 2019, 07:27
Closed by commit rABCf2225b39dcc4: Added missing notes to release notes (authored by jasonbcox). · Explain WhyApr 21 2019, 17:00
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGf2225b39dcc4: Added missing notes to release notes.Sep 18 2019, 23:05

Revision Contents
Changeset List

PathSize
doc/
2 lines

Diff 8129

View Options

doc/release-notes.md

Loading...