Page MenuHomePhabricator
Differential D318

Update README and Release notes for 0.14.3
ClosedPublic
Actions

Authored by Mengerian on Jul 11 2017, 22:33.

Details

Reviewers
deadalnix
freetrader
sickpig
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING2ba4f7c0edb4: Update README and Release notes for 0.14.3
rABC2ba4f7c0edb4: Update README and Release notes for 0.14.3
Summary

Change version numbers for ABC 0.14.3 release:

configure.ac
doc/README.md
doc/release-notes.md
src/test/net_tests.cpp

Move older release notes to doc/release-notes/

Test Plan

None

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rel-14-2
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc\test\net_tests.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 512
Build 512: arc lint + arc unit

Event Timeline

Mengerian created this revision.Jul 11 2017, 22:33
Owners added a reviewer: Restricted Owners Package.Jul 11 2017, 22:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2017, 22:33
freetrader added inline comments.Jul 12 2017, 06:53
doc/release-notes.md
5 ↗(On Diff #794)

This is including several mistakes from the original content.

Here's a rough attempt at correction:

This release include various changes. The most notable is a change to the difficulty adjustment algorithm which decreases the difficulty in case the hashrate becomes very low. We obviously hope that this feature will not need to be used, and it would not kick in if the hashrate stays above 8% of the global hashrate. However, it ensures that this chain will survive no matter what, as long as someone thinks it is valuable.

freetrader added inline comments.Jul 12 2017, 06:54
doc/release-notes.md
5 ↗(On Diff #794)

I missed another one in the first sentence:

This release includes various changes.

freetrader requested changes to this revision.Jul 12 2017, 06:57
freetrader added inline comments.
doc/README.md
1 ↗(On Diff #794)

Would it be an opportune time to replace Core by ABC in this document?

6 ↗(On Diff #794)

One could rephrase to "Bitcoin ABC is a derivative of Bitcoin Core, the original ..."

This revision now requires changes to proceed.Jul 12 2017, 06:57
Mengerian updated this revision to Diff 804.Jul 13 2017, 23:48
Mengerian edited edge metadata.

Updates based on @freetrader's comments.

Ended up fully De-Coreifyin the README.

Fixed wording of release notes based on freetrader's corrections

Mengerian marked 4 inline comments as done.Jul 13 2017, 23:50

OK, I updated the diff to fix the issues identified by @freetrader

Mengerian updated this revision to Diff 805.Jul 13 2017, 23:53

Fix download link in release notes

deadalnix added inline comments.Jul 13 2017, 23:58
doc/README.md
1 ↗(On Diff #805)

0.14.3 now :) We missed the boat for 0.14.2 .

freetrader accepted this revision.Jul 13 2017, 23:59

Looks good to me.

This revision is now accepted and ready to land.Jul 13 2017, 23:59
deadalnix requested changes to this revision.Jul 14 2017, 01:17

No please bump to 0.14.3 . Then it's good to go.

This revision now requires changes to proceed.Jul 14 2017, 01:17
Mengerian added a comment.Jul 14 2017, 14:10
In D318#5394, @deadalnix wrote:

No please bump to 0.14.3 . Then it's good to go.

In that case, may as well also change to 0.14.3 in configure.ca and /src/test/net_tests.cpp in this diff

Mengerian edited the summary of this revision. (Show Details)Jul 14 2017, 14:29
Mengerian retitled this revision from Update README and Release notes for 0.14.2 to Update README and Release notes for 0.14.3.
Mengerian updated this revision to Diff 819.Jul 14 2017, 15:03
Mengerian edited edge metadata.

Update for 0.14.3 release

Mengerian updated this revision to Diff 820.Jul 14 2017, 15:08

rebase commit on master

freetrader accepted this revision.Jul 14 2017, 15:17
sickpig accepted this revision.Jul 14 2017, 15:19
sickpig added a subscriber: sickpig.

proof read, everything seems ok.

deadalnix accepted this revision.Jul 14 2017, 15:37
This revision is now accepted and ready to land.Jul 14 2017, 15:37
Closed by commit rABC2ba4f7c0edb4: Update README and Release notes for 0.14.3 (authored by Mengerian, committed by Mengerian). · Explain WhyJul 14 2017, 15:47
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
doc/
18 lines
144 lines
release-notes/
release-notes-0.14.1.md
release-notes.md
143 lines
release-notes/
5 lines
src/
test/
2 lines

Diff 819

View Options

configure.ac

Loading...
View Options

doc/README.md

Loading...
View Options

doc/release-notes.md

Loading...
View Options

doc/release-notes/release-notes-0.14.1.md

Loading...
View Options

doc/release-notes/release-notes-0.14.2.md

Loading...
View Options

src/test/net_tests.cpp

Loading...