Page MenuHomePhabricator

[LINTER] Remove the lint-format-strings.sh script
ClosedPublic

Authored by Fabien on Apr 26 2019, 16:56.

Details

Summary

The python script is now called directly by a dedicated PHP linter.
This avoids the bash intermediate step and cuts the time by about 3x.

Depends on D2882

Test Plan
arc lint --everything

Should return no error

Comment any of the false positive at the beginning of the
lint-format-strings.py file.

arc lint --everything

Ensure the false positive are catched by the linter.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lint_format_string_performance_improve_3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5612
Build 9286: Bitcoin ABC Buildbot (legacy)
Build 9285: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 30 2019, 23:24

Fix typo in file name: FormaStringLinter.php => FormatStringLinter.php

This revision was automatically updated to reflect the committed changes.