HomePhabricator

[LINTER] Remove the lint-format-strings.sh script

Description

[LINTER] Remove the lint-format-strings.sh script

Summary:
The python script is now called directly by a dedicated PHP linter.
This avoids the bash intermediate step and cuts the time by about 3x.

Depends on D2882

Test Plan:

arc lint --everything

Should return no error

Comment any of the false positive at the beginning of the
lint-format-strings.py file.

arc lint --everything

Ensure the false positive are catched by the linter.

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D2883

Details

Provenance
FabienAuthored on Apr 26 2019, 16:50
jasonbcoxPushed on May 1 2019, 22:52
Reviewer
Restricted Project
Differential Revision
D2883: [LINTER] Remove the lint-format-strings.sh script
Parents
rSTAGING93e2cadf33ff: [LINTER] Move the string formatting function list to the python script
Branches
Unknown
Tags
Unknown