Page MenuHomePhabricator
Differential D2926

blockfilter: Use unordered_set instead of set in blockfilter.
ClosedPublic
Actions

Authored by markblundeberg on May 5 2019, 02:24.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T589: BIP157 & BIP158 backports
Commits
rSTAGING8c7bbe889ce8: blockfilter: Use unordered_set instead of set in blockfilter.
rABC8c7bbe889ce8: blockfilter: Use unordered_set instead of set in blockfilter.
Summary

remaining backport of PR14074:
fef5adcc3 blockfilter: Use unordered_set instead of set in blockfilter.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
blockfilter_unset
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5677
Build 9416: Bitcoin ABC Buildbot (legacy)
Build 9415: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 5 2019, 02:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2019, 02:24
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg planned changes to this revision.May 5 2019, 02:24
markblundeberg added a task: T589: BIP157 & BIP158 backports.
teamcity added a comment.May 5 2019, 02:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg updated this revision to Diff 8392.May 5 2019, 02:29

de-charring

teamcity added a comment.May 5 2019, 02:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5676: Diff 8391.May 5 2019, 02:39
teamcity added a comment.May 5 2019, 02:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.May 5 2019, 02:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5677: Diff 8392.May 5 2019, 02:44
markblundeberg edited the summary of this revision. (Show Details)May 5 2019, 17:08
markblundeberg added a comment.EditedMay 5 2019, 17:13

Note -- Previously I thought this should be done after T590 (which creates the util/ directory) but it appears to be just fine like this - it sits in the same directory but is entirely independent.

markblundeberg added a reviewer: Fabien.May 6 2019, 19:33
deadalnix accepted this revision.May 6 2019, 21:14
This revision is now accepted and ready to land.May 6 2019, 21:14
Closed by commit rABC8c7bbe889ce8: blockfilter: Use unordered_set instead of set in blockfilter. (authored by jimpo, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 6 2019, 22:37
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING8c7bbe889ce8: blockfilter: Use unordered_set instead of set in blockfilter..Sep 18 2019, 23:17

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
5 lines
util/
26 lines
16 lines

Diff 8392

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/blockfilter.h

Loading...
View Options

src/util/bytevectorhash.h

Loading...
View Options

src/util/bytevectorhash.cpp

Loading...