Page MenuHomePhabricator
Differential D2958

Merge #12415: Interrupt loading thread after shutdown request
ClosedPublic
Actions

Authored by jasonbcox on May 7 2019, 00:43.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING034171f92e1b: Merge #12415: Interrupt loading thread after shutdown request
rABC034171f92e1b: Merge #12415: Interrupt loading thread after shutdown request
Summary

2e9406c Interrupt loading thread after shutdown request (João Barbosa)

Pull request description:

This change (currently) avoids loading the mempool if shutdown is requested.

Tree-SHA512: 3dca3a6ea5b09bd71db0974584d93dfe81819bc0bdbb4d9b6fa0474755306d1403f6c058ecb8211384493a8f7ca3a9134173db744b7344043cfc7d79286c8fd4

Backport of Core PR12415
https://github.com/bitcoin/bitcoin/pull/12415/files

Test Plan

make check
test_runner.py
bitcoind --testnet -help-debug -stopafterblockimport # shuts down as expected with this message in the logs: Stopping after block import

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12415
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5785
Build 9632: Bitcoin ABC Buildbot (legacy)
Build 9631: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 7 2019, 00:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 00:43
teamcity added a comment.May 7 2019, 00:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 7 2019, 00:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5717: Diff 8445.May 7 2019, 00:57
Fabien requested changes to this revision.May 7 2019, 06:24

Please update the test plan, make check does not cover the behavior change.

This revision now requires changes to proceed.May 7 2019, 06:24
jasonbcox edited the summary of this revision. (Show Details)May 9 2019, 00:15
jasonbcox edited the test plan for this revision. (Show Details)May 9 2019, 22:49
jasonbcox updated this revision to Diff 8570.May 9 2019, 22:57

Rebase

jasonbcox edited the test plan for this revision. (Show Details)May 9 2019, 22:58
teamcity added a comment.May 9 2019, 22:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 9 2019, 23:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5785: Diff 8570.May 9 2019, 23:12
Fabien accepted this revision.May 10 2019, 15:07
This revision is now accepted and ready to land.May 10 2019, 15:07
Closed by commit rABC034171f92e1b: Merge #12415: Interrupt loading thread after shutdown request (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 10 2019, 15:16
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING034171f92e1b: Merge #12415: Interrupt loading thread after shutdown request.Sep 18 2019, 23:29

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 8570

View Options

src/init.cpp

Loading...