Page MenuHomePhabricator
Differential D3042

Remove useless include of boost thread
ClosedPublic
Actions

Authored by deadalnix on May 14 2019, 16:01.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGf4cea37d423c: Remove useless include of boost thread
rABCf4cea37d423c: Remove useless include of boost thread
Summary

We probably want to get rid of it at some point now that we are using C++11 but in the meantime, we can limit the spread of the infection.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
removeinclude
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5844
Build 9750: Bitcoin ABC Buildbot (legacy)
Build 9749: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 14 2019, 16:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2019, 16:01
teamcity added a comment.May 14 2019, 16:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 14 2019, 16:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5844: Diff 8651.May 14 2019, 16:16
jasonbcox accepted this revision.May 14 2019, 16:39
jasonbcox added a subscriber: jasonbcox.

iirc there are backports that do similar things, but this is a good start regardless

This revision is now accepted and ready to land.May 14 2019, 16:39
Closed by commit rABCf4cea37d423c: Remove useless include of boost thread (authored by deadalnix). · Explain WhyMay 14 2019, 19:06
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D3054: Fix boost::thread::interruption_point causing build failure on Windows.May 15 2019, 15:50
Fabien mentioned this in rABC610f36bf9772: Fix boost::thread::interruption_point causing build failure on Windows.May 15 2019, 20:15
deadalnix added a commit: rSTAGINGf4cea37d423c: Remove useless include of boost thread.Sep 18 2019, 23:31
Fabien mentioned this in rSTAGING610f36bf9772: Fix boost::thread::interruption_point causing build failure on Windows.Sep 18 2019, 23:33

Revision Contents
Changeset List

PathSize
src/
2 lines
qt/
1 line
test/
4 lines
1 line
2 lines
2 lines
1 line
wallet/
1 line
2 lines
1 line

Diff 8651

View Options

src/bitcoind.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/test/checkqueue_tests.cpp

Loading...
View Options

src/test/scheduler_tests.cpp

Loading...
View Options

src/test/test_bitcoin.h

Loading...
View Options

src/txdb.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...