Page MenuHomePhabricator
Differential D3086

Merge #12849: Tests: Add logging in loops in p2p_sendhears.py
ClosedPublic
Actions

Authored by markblundeberg on May 21 2019, 19:21.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T654: fix p2p_sendheaders
Commits
rSTAGING3653fcd20787: Merge #12849: Tests: Add logging in loops in p2p_sendhears.py
rABC3653fcd20787: Merge #12849: Tests: Add logging in loops in p2p_sendhears.py
Summary

PR12849 backport https://github.com/bitcoin/bitcoin/pull/12849/files
8dd547d82b Adding logging for loop iteration level in p2p_sendheaders.py (ccdle12)

Pull request description:

PR for #12453

New contributor looking at mainly the 'good first issues'.

From my understanding of the issue:
 * Track the iteration level of loop when test fails in Travis CI

Further clarification on the issue would be greatly appreciated to narrow down what can be fixed or updated.

Depends on D3085

Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixp2p
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5929
Build 9918: Bitcoin ABC Buildbot (legacy)
Build 9917: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 21 2019, 19:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2019, 19:21
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 21 2019, 19:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T654: fix p2p_sendheaders.May 21 2019, 19:22
teamcity added a comment.May 21 2019, 19:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5929: Diff 8783.May 21 2019, 19:36
markblundeberg added a child revision: D3087: Merge #13192: [tests] Fixed intermittent failure in p2p_sendheaders.py..May 21 2019, 19:55
deadalnix accepted this revision.May 21 2019, 21:14
This revision is now accepted and ready to land.May 21 2019, 21:14
Closed by commit rABC3653fcd20787: Merge #12849: Tests: Add logging in loops in p2p_sendhears.py (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 21 2019, 21:40
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING3653fcd20787: Merge #12849: Tests: Add logging in loops in p2p_sendhears.py.Sep 18 2019, 23:39

Revision Contents
Changeset List

PathSize
test/
functional/
14 lines

Diff 8783

View Options

test/functional/p2p_sendheaders.py

Loading...