Page MenuHomePhabricator
Differential D3087

Merge #13192: [tests] Fixed intermittent failure in p2p_sendheaders.py.
ClosedPublic
Actions

Authored by markblundeberg on May 21 2019, 19:55.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T453: Backport Core PR13192
Commits
rSTAGING592081389f0c: Merge #13192: [tests] Fixed intermittent failure in p2p_sendheaders.py.
rABC592081389f0c: Merge #13192: [tests] Fixed intermittent failure in p2p_sendheaders.py.
Summary

PR13192 backport https://github.com/bitcoin/bitcoin/pull/13192/files
12d1b77f7e [tests] Fixed intermittent failure in p2p_sendheaders.py. (lmanners)

Pull request description:

Added handling for the case where headers are announced over more than one message.
refs #12453

Depends on D3086

Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixp2p
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5930
Build 9920: Bitcoin ABC Buildbot (legacy)
Build 9919: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 21 2019, 19:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2019, 19:55
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 21 2019, 19:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T453: Backport Core PR13192.May 21 2019, 19:56

Ironically I am having a hard time reproducing the failure mode, now that I actually want to see the before/after change. 🙄

markblundeberg added a child revision: D3088: Merge #13350: [tests] Add logging to provide anchor points when debugging p2p_sendheaders.May 21 2019, 20:01
Harbormaster completed remote builds in B5930: Diff 8784.May 21 2019, 20:11
teamcity added a comment.May 21 2019, 20:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.May 21 2019, 21:15
This revision is now accepted and ready to land.May 21 2019, 21:15
Closed by commit rABC592081389f0c: Merge #13192: [tests] Fixed intermittent failure in p2p_sendheaders.py. (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 21 2019, 21:40
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING592081389f0c: Merge #13192: [tests] Fixed intermittent failure in p2p_sendheaders.py..Sep 18 2019, 23:39

Revision Contents
Changeset List

PathSize
test/
functional/
97 lines

Diff 8784

View Options

test/functional/p2p_sendheaders.py

Loading...