tests: move pwalletMain to wallet test fixture
ClosedPublic
Actions

Authored by Fabien on May 23 2019, 13:04.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING90e59928c007: tests: move pwalletMain to wallet test fixture
rABC90e59928c007: tests: move pwalletMain to wallet test fixture

Summary

Scope the variable instead of using an external global; this is how test
fixtures are intended to be used.

Followup to #11713.

Backport of core PR11718
https://github.com/bitcoin/bitcoin/pull/11718/files

Depends on D3097
Completes T659

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11718

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5953
Build 9966: Bitcoin ABC Buildbot (legacy)
Build 9965: arc lint + arc unit

Event Timeline

Fabien created this revision.May 23 2019, 13:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2019, 13:04

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5953: Diff 8821.May 23 2019, 13:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.May 23 2019, 21:56

This revision is now accepted and ready to land.May 23 2019, 21:56

Closed by commit rABC90e59928c007: tests: move pwalletMain to wallet test fixture (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Fabien). · Explain WhyMay 24 2019, 06:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC90e59928c007: tests: move pwalletMain to wallet test fixture.

Fabien added a commit: rSTAGING90e59928c007: tests: move pwalletMain to wallet test fixture.Sep 18 2019, 23:43

Revision Contents
Changeset List

Path

Size

src/

wallet/

test/

accounting_tests.cpp

17 lines

wallet_test_fixture.h

4 lines

wallet_test_fixture.cpp

4 lines

wallet_tests.cpp

2 lines

Diff 8821

View Options

src/wallet/test/accounting_tests.cpp

View Options

src/wallet/test/wallet_test_fixture.h

View Options

src/wallet/test/wallet_test_fixture.cpp

View Options

src/wallet/test/wallet_tests.cpp

tests: move pwalletMain to wallet test fixtureClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8821

src/wallet/test/accounting_tests.cpp

src/wallet/test/wallet_test_fixture.h

src/wallet/test/wallet_test_fixture.cpp

src/wallet/test/wallet_tests.cpp

tests: move pwalletMain to wallet test fixture
ClosedPublic
Actions

Revision Contents
Changeset List