Page MenuHomePhabricator
Differential D3129

Extend validateaddress information for P2SH-embedded witness
ClosedPublic
Actions

Authored by deadalnix on May 27 2019, 15:36.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING0b8962a4a9f4: Extend validateaddress information for P2SH-embedded witness
rABC0b8962a4a9f4: Extend validateaddress information for P2SH-embedded witness
Summary

This adds new fields 'pubkeys' and 'embedded' to the RPC's output, and improves the
documentation for previously added 'witness_version' and 'witness_program' fields.

This is a partial backport of Core PR11403 : https://github.com/bitcoin/bitcoin/pull/11403/commits/3eaa003c888f80207e8ff132f78417ff373ddfa3

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
validateaddress
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6012
Build 10083: Bitcoin ABC Buildbot (legacy)
Build 10082: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 27 2019, 15:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2019, 15:36
teamcity added a comment.May 27 2019, 15:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 27 2019, 15:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6012: Diff 8922.May 27 2019, 15:51
deadalnix added a child revision: D3133: SegWit wallet support.May 27 2019, 18:31
markblundeberg accepted this revision.May 28 2019, 00:39
markblundeberg added a subscriber: markblundeberg.

man this is confusing stuff...

This revision is now accepted and ready to land.May 28 2019, 00:39
deadalnix added a child revision: D3138: [rpc] split wallet and non-wallet parts of DescribeAddressVisitor.May 28 2019, 00:49
Closed by commit rABC0b8962a4a9f4: Extend validateaddress information for P2SH-embedded witness (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyMay 28 2019, 11:25
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC0b8962a4a9f4: Extend validateaddress information for P2SH-embedded witness.
deadalnix added a commit: rSTAGING0b8962a4a9f4: Extend validateaddress information for P2SH-embedded witness.Sep 18 2019, 23:50

Revision Contents
Changeset List

PathSize
src/
rpc/
105 lines
script/
4 lines

Diff 8922

View Options

src/rpc/misc.cpp

Loading...
View Options

src/script/standard.h

Loading...