Differential D3136

Remove IsSolvable
ClosedPublic
Actions

Authored by deadalnix on May 27 2019, 21:38.

Details

Reviewers

markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGINGfa09461d4e80: Remove IsSolvable
rABCfa09461d4e80: Remove IsSolvable

Summary

It was introduce to help for the segwit wallet backport, but is not useful now and can be removed.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 27 2019, 21:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2019, 21:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6023: Diff 8937.May 27 2019, 21:53

markblundeberg accepted this revision.May 28 2019, 02:43

This revision is now accepted and ready to land.May 28 2019, 02:43

Closed by commit rABCfa09461d4e80: Remove IsSolvable (authored by deadalnix). · Explain WhyMay 28 2019, 11:30

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCfa09461d4e80: Remove IsSolvable.

deadalnix added a commit: rSTAGINGfa09461d4e80: Remove IsSolvable.Sep 18 2019, 23:50

nakihito mentioned this in D4736: Merge #13534: Don't assert(foo()) where foo() has side effects.Dec 17 2019, 00:37

markblundeberg mentioned this in D3121: Abstract out IsSolvable from Witnessifier.Jan 12 2020, 11:32

markblundeberg mentioned this in D4912: Reintroduce IsSolvable.Jan 12 2020, 12:48

Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC9dda12ee9286: Reintroduce IsSolvable.Jan 13 2020, 00:59

Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING9dda12ee9286: Reintroduce IsSolvable.Apr 7 2020, 22:23

Revision Contents
Changeset List

Path

Size

src/

script/

sign.h

8 lines

sign.cpp

16 lines

Diff 8956

View Options

src/script/sign.h