Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests
ClosedPublic
Actions

Authored by Mengerian on May 28 2019, 05:22.

Details

Reviewers

deadalnix
markblundeberg
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING11febd55e5a8: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests
rABC11febd55e5a8: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests

Summary

Now that the flag has no effect on the validity of OP_CHECKDATASIG in scripts,
it is unnecessary to pass it into script tests.

The fact that the flag does not affect validity of the opcode is tested in the
checkdatasig_tests.cpp unit tests, and the effect of the flag on sigops counting
is tested in sigopcount_tests.cpp

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cds-remove-flag-from-script-tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6037
Build 10133: Bitcoin ABC Buildbot (legacy)
Build 10132: arc lint + arc unit

Event Timeline

Mengerian created this revision.May 28 2019, 05:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2019, 05:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6031: Diff 8948.May 28 2019, 05:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien requested changes to this revision.May 28 2019, 11:04

Fabien added inline comments.

src/test/data/script_tests.json
257 ↗	(On Diff #8948)	Dropping the flag make these tests getting duplicated, you can remove them.

This revision now requires changes to proceed.May 28 2019, 11:04

Remove duplicate test cases

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix requested changes to this revision.May 28 2019, 15:22

deadalnix added inline comments.

src/test/scriptflags.cpp
34	Keep

This revision now requires changes to proceed.May 28 2019, 15:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6037: Diff 8963.May 28 2019, 15:27

Mengerian added inline comments.May 28 2019, 15:30

src/test/scriptflags.cpp
34	Do you mind if I change the name of the flag in the tests to "CHECKDATASIG_SIGOPS"? I think that makes the tests more readable. It's mildly confusing (and worse for searching) that the name of the flag is exactly the same as the name of the opcode. (If the flag ever ends up getting used again)