Reintroduce the concept of virtual size from core
ClosedPublic
Actions

Authored by deadalnix on Jun 3 2019, 13:37.

Details

Reviewers

markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGING87136e28b370: Reintroduce the concept of virtual size from core
rABC87136e28b370: Reintroduce the concept of virtual size from core

Summary

Bitcoin Core use the concept of virtual size to compute custom fees. We do not need to implement a ton of custom logic for our fee if we reuse that work.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

virtualsize

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6125
Build 10298: Bitcoin ABC Buildbot (legacy)
Build 10297: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 3 2019, 13:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2019, 13:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6116: Diff 9080.Jun 3 2019, 13:52

markblundeberg added a subscriber: markblundeberg.Jun 3 2019, 14:03

markblundeberg added inline comments.

src/policy/policy.cpp
183 ↗	(On Diff #9080)	Given that we're using custom logic here anyway by not using `GetTransactionWeight`, can we use a different term than "nWeight"? (weight is such a vague term; the core version of this function weights sigops into an already-weighted "weight units"). Suggestion: nSize, nBytes, nRealSize, nRawSize, ...