Page MenuHomePhabricator
Differential D366

Add NODE_BITCOIN_CASH service bit
ClosedPublic
Actions

Authored by freetrader on Jul 22 2017, 06:16.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGbfd7b2222ef0: Add NODE_BITCOIN_CASH service bit
rABCbfd7b2222ef0: Add NODE_BITCOIN_CASH service bit
Summary

This is a port of Unlimited's PR705 which introduces a service bit for Bitcoin
Cash nodes. This helps differentiate nodes which support the fork ahead of
fork time, which is valuable for DNS seeders.

Test Plan

make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add_node_bitcoin_cash_service_bit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 564
Build 564: arc lint + arc unit

Event Timeline

freetrader created this revision.Jul 22 2017, 06:16
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJul 22 2017, 06:16
Harbormaster completed remote builds in B564: Diff 910.Jul 22 2017, 06:16
deadalnix accepted this revision.Jul 22 2017, 10:58
This revision is now accepted and ready to land.Jul 22 2017, 10:58
Closed by commit rABCbfd7b2222ef0: Add NODE_BITCOIN_CASH service bit (authored by freetrader, committed by freetrader). · Explain WhyJul 22 2017, 11:43
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
qa/
rpc-tests/
10 lines
test_framework/
2 lines
src/
5 lines
7 lines
qt/
3 lines

Diff 910

View Options

qa/rpc-tests/abc-rpc.py

Loading...
View Options

qa/rpc-tests/test_framework/mininode.py

Loading...
View Options

src/init.cpp

Loading...
View Options

src/protocol.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...